reuvenlax commented on code in PR #17417: URL: https://github.com/apache/beam/pull/17417#discussion_r863995882
########## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java: ########## @@ -19,12 +19,14 @@ import static org.apache.beam.vendor.guava.v26_0_jre.com.google.common.base.Preconditions.checkArgument; +import com.google.api.core.ApiFuture; import com.google.cloud.bigquery.storage.v1.AppendRowsResponse; import com.google.cloud.bigquery.storage.v1.ProtoRows; import com.google.cloud.bigquery.storage.v1.WriteStream.Type; import com.google.protobuf.ByteString; import com.google.protobuf.DynamicMessage; import java.io.IOException; +import java.time.Instant; Review Comment: java Instant is the recommended class to use. We continue using Joda in public APIs (and in encoded bytes) for backwards compatibility reasons, but for internal uses like this java time is nicer to use. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
