TheNeuralBit commented on code in PR #17384: URL: https://github.com/apache/beam/pull/17384#discussion_r864047641
########## sdks/python/apache_beam/utils/windowed_value.pxd: ########## @@ -43,6 +43,23 @@ cdef class WindowedValue(object): cpdef WindowedValue with_value(self, new_value) +cdef class WindowedBatch(object): + cpdef WindowedBatch with_values(self, object new_values) + +cdef class HomogeneousWindowedBatch(WindowedBatch): + cdef public WindowedValue _wv + + cpdef WindowedBatch with_values(self, object new_values) + +cdef class ConcreteWindowedBatch(WindowedBatch): + cdef public object values Review Comment: yeah the WindowedValue(None) approach could make sense. The downside is it's not "columnar", but for that matter neither is the current implementation based on python lists. An optimized version could be yet another future WindowedBatch implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
