nielm commented on PR #17540: URL: https://github.com/apache/beam/pull/17540#issuecomment-1117601142
I am not sure what you mean by 'supressions' here? (This issue is unrelated to the suppression of runtime exceptions in Spanner, GCS, DataStore connectors) The NPE was introduced in 2.35 (along with the other issue) by the implementor of the MontoringInfoMetrics, who assumed that the projectId could never be null. I fixed this in 2.37, but assumed naively/incorrectly that the projectID _valueProvider object_ would always be null when a value was not present - which is normally true for command line executions but not for template executions (nor when a user explicitly passes a null value). This was not noticed until an unrelated change used an ImmutableMap for MontoringInfoMetricName keys, which enforced non-null values (in 2.38). So yes it is still possible that there are various NPEs waiting to be found in other IOs where MonitoringInfoMetrics were added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
