TheNeuralBit commented on PR #17517: URL: https://github.com/apache/beam/pull/17517#issuecomment-1118017910
Thanks @Firlej! I triggers a CI check that should exercise this new test. This looks good, I guess my only concern is this could be a breaking change for existing users, e.g. if they're unpacking the current result `destination, row = value`. I think that's OK as long as we document this as a breaking change in CHANGES.md, but I think @chamikaramj or @pabloem should make that call. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
