kerrydc commented on code in PR #17383: URL: https://github.com/apache/beam/pull/17383#discussion_r866115080
########## .test-infra/jenkins/job_ClusterCredentialsRotation.groovy: ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import CommonJobProperties as commonJobProperties + +job('Rotate Cluster Credentials') { + description('Rotates Certificates and performs an IP rotation for metrics and io-datastores') + + // Set common parameters. + commonJobProperties.setTopLevelMainJobProperties(delegate) + + // Sets that this is a cron job. + commonJobProperties.setCronJob(delegate, 'H 2 1 */2 *')// At 00:02am every second month. + + steps { + + //Credentials rotation for metrics and io-datastores + + //Set a maintenance window + shell('''gcloud container clusters update metrics \ + --zone=us-central1-a --maintenance-window=06:00 --quiet''') + + shell('''gcloud container clusters update io-datastores \ + --zone=us-central1-a --maintenance-window=06:00 --quiet''') + + //Starting credential rotation + // it's necessary to rebuild the nodes after rotation to avoid apiservices issues + shell('''gcloud container clusters update metrics \ + --start-credential-rotation --zone=us-central1-a --quiet''') + + shell('''gcloud container clusters update io-datastores \ + --start-credential-rotation --zone=us-central1-a --quiet''') + + //Rebuilding the nodes + shell('''gcloud container clusters upgrade metrics \ Review Comment: What happens if these commands close with an error state? ########## .test-infra/jenkins/job_ClusterCredentialsRotation.groovy: ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import CommonJobProperties as commonJobProperties + +job('Rotate Cluster Credentials') { + description('Rotates Certificates and performs an IP rotation for metrics and io-datastores') + + // Set common parameters. + commonJobProperties.setTopLevelMainJobProperties(delegate) + + // Sets that this is a cron job. + commonJobProperties.setCronJob(delegate, 'H 2 1 */2 *')// At 00:02am every second month. + + steps { + + //Credentials rotation for metrics and io-datastores + + //Set a maintenance window + shell('''gcloud container clusters update metrics \ + --zone=us-central1-a --maintenance-window=06:00 --quiet''') + + shell('''gcloud container clusters update io-datastores \ + --zone=us-central1-a --maintenance-window=06:00 --quiet''') Review Comment: same here. ########## .test-infra/jenkins/job_ClusterCredentialsRotation.groovy: ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import CommonJobProperties as commonJobProperties + +job('Rotate Cluster Credentials') { + description('Rotates Certificates and performs an IP rotation for metrics and io-datastores') + + // Set common parameters. + commonJobProperties.setTopLevelMainJobProperties(delegate) + + // Sets that this is a cron job. + commonJobProperties.setCronJob(delegate, 'H 2 1 */2 *')// At 00:02am every second month. + + steps { + + //Credentials rotation for metrics and io-datastores + + //Set a maintenance window + shell('''gcloud container clusters update metrics \ + --zone=us-central1-a --maintenance-window=06:00 --quiet''') Review Comment: Why do you set a daily maintenance window for 6AM UTC? This command sets a daily 4 hour maintenance window. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
