robertwb commented on code in PR #17563: URL: https://github.com/apache/beam/pull/17563#discussion_r866288606
########## sdks/python/setup.py: ########## @@ -272,6 +162,8 @@ def get_portability_package_data(): # structure must exist before the call to setuptools.find_packages() # executes below. generate_protos_first() + # We can't move the dependencies out of the setup call, otherwise Review Comment: Rather than phrase this as a negative, I would say "Keep all dependencies inlined in the setup call, otherwise..." -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
