svetakvsundhar commented on code in PR #17159:
URL: https://github.com/apache/beam/pull/17159#discussion_r866406831
##########
sdks/python/apache_beam/io/gcp/bigquery.py:
##########
@@ -2525,6 +2526,12 @@ def _get_pipeline_details(unused_elm):
**self._kwargs))
| _PassThroughThenCleanupTempDatasets(project_to_cleanup_pcoll))
+ def get_pcoll_from_schema(table_schema):
+ pcoll_val = apache_beam.io.gcp.bigquery_schema_tools.\
+ produce_pcoll_with_schema(table_schema)
+ return beam.Map(lambda values: pcoll_val(**values)).with_output_types(
Review Comment:
@TheNeuralBit , tried this here but looks like the pickling still had an
error. Something to note is that this is able to run fine on Colab notebook via
DirectRunner
(https://colab.sandbox.google.com/drive/1_BkzBwCLB7OjR1jGGzCkxXFHreUZgCZl#revisionId=0BzxzuriHpr5fcXNOWHcvcGlqYTBWWUZxRWdQaFIrVVFYV0Y4PQ&scrollTo=YITcZHkoZR59)
Could you expand more on why we shouldn't be pickling these instances? ```In
general, we shouldn't be pickling these instances, but occasionally it may be
necessary``` (from the JIRA description)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
