robertwb commented on code in PR #17482:
URL: https://github.com/apache/beam/pull/17482#discussion_r867263904
##########
sdks/python/apache_beam/transforms/fully_qualified_named_transform_test.py:
##########
@@ -116,6 +119,14 @@ def test_glob_filter(self):
with self.assertRaises(ValueError):
FullyQualifiedNamedTransform._resolve('apache_beam.Row')
+ @patch('importlib.import_module')
+ def test_resolve(self, mock_import_module):
Review Comment:
Sorry to be a stickler, but this mocking doesn't actually convince me that
the code in question actually does the right thing. Could you actually perform
an import here so that we know we're interacting with the import module in the
right way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
