riteshghorse commented on code in PR #17575:
URL: https://github.com/apache/beam/pull/17575#discussion_r868237662
##########
sdks/go/pkg/beam/core/runtime/exec/datasource.go:
##########
@@ -596,8 +596,12 @@ func splitHelper(
if bestS != -1 {
return bestS, -1.0, nil
}
-
- return -1, -1.0, fmt.Errorf("failed to split DataSource (at index: %v)
at requested splits: {%v}", currIdx, splits)
+ // Printing all splits is expensive. Instead, return the current start
and
+ // end indices, and fraction along with the range of the indices and how
+ // many there are. This branch requires least one split index, so we
don't
Review Comment:
```suggestion
// many there are. This branch requires at least one split index, so we
don't
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
