[GitHub] [beam] tvalentyn commented on a diff in pull request #17530: BEAM-5492 Python Dataflow integration tests should export the pipeline console output to Jenkins Test Result section

[GitBox]

tvalentyn commented on code in PR #17530:
URL: https://github.com/apache/beam/pull/17530#discussion_r868310486


##########
sdks/python/apache_beam/runners/dataflow/test_dataflow_runner.py:
##########
@@ -84,7 +86,10 @@ def build_console_url(self, options):
 
   def wait_until_in_state(self, expected_state, timeout=WAIT_IN_STATE_TIMEOUT):
     """Wait until Dataflow pipeline enters a certain state."""
+    consoleUrl = """Console URL:https://console.cloud.google.com/dataflow/jobs/

Review Comment:
   ```suggestion
       consoleUrl = """Console URL: 
https://console.cloud.google.com/dataflow/jobs/
   ```



##########
sdks/python/apache_beam/runners/dataflow/dataflow_runner.py:
##########
@@ -1628,11 +1630,13 @@ def wait_until_finish(self, duration=None):
       # is_in_terminal_state.
       terminated = self.is_in_terminal_state()
       assert duration or terminated, (
-          'Job did not reach to a terminal state after waiting indefinitely.')
+          'Job did not reach to a terminal state after waiting indefinitely.'

Review Comment:
   ```suggestion
             'Job did not reach to a terminal state after waiting indefinitely. 
'
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org