igorbernstein2 commented on code in PR #16939:
URL: https://github.com/apache/beam/pull/16939#discussion_r870641154
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableServiceImpl.java:
##########
@@ -210,6 +212,254 @@ public Row getCurrentRow() throws NoSuchElementException {
}
}
+ @VisibleForTesting
+ static class BigtableSegmentReaderImpl implements Reader {
+ private BigtableSession session;
+
+ @Nullable ReadRowsRequest nextRequest;
+ final Queue<Row> buffer = new ArrayDeque<>();
+ final int segmentSize;
+ final int refillSegmentWaterMark;
+ final String tableId;
+ final RowFilter filter;
+ final long bufferByteLimit;
Review Comment:
make everything private unless you need for testing and in that annotate
with VisibleForTesting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
