mosche commented on code in PR #17406:
URL: https://github.com/apache/beam/pull/17406#discussion_r871217253


##########
runners/spark/src/main/java/org/apache/beam/runners/spark/translation/SparkContextFactory.java:
##########
@@ -36,7 +36,8 @@ public final class SparkContextFactory {
    * context will be reused for beam pipelines. This property should only be 
enabled for tests.
    *
    * @deprecated Please use {@link SparkContextOptions} instead to allow for 
proper lifecycle

Review Comment:
   I've added more guidelines, though `SparkContextRule` only exists in the 
test scope and is not published ... should somebody try and use the SparkRunner 
for their own tests instead of the direct runner (for whatever reason) that's 
might be confusing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to