chamikaramj commented on PR #17599: URL: https://github.com/apache/beam/pull/17599#issuecomment-1125129268
To clarify, next steps are. (1) A brief design doc on why this approach works for reading/writing 4mc files (or propose an alternative approach) (2) Make sure that the PR passes current tests (3) Add new unit tests related to reading and writing with 4mc compression. See [1] and [2] for example tests. (4) Add an integration test (optional) [1] https://github.com/apache/beam/blob/master/sdks/java/core/src/test/java/org/apache/beam/sdk/io/TextIOWriteTest.java [2] https://github.com/apache/beam/blob/master/sdks/java/core/src/test/java/org/apache/beam/sdk/io/TextIOWriteTest.java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
