TheNeuralBit commented on code in PR #17608:
URL: https://github.com/apache/beam/pull/17608#discussion_r871661762
##########
model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/beam_runner_api.proto:
##########
@@ -1094,6 +1094,13 @@ message StandardCoders {
}
}
+message LogicalTypes {
Review Comment:
Yeah I'd be in favor of that. A couple of other suggestions:
- I think it would make sense to move this enum to schema.proto with all the
other representations for the type system
- This should document the representation type, argument type, and the
meaning of the logical type, as we do in the comment you linked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
