kennknowles commented on code in PR #17244: URL: https://github.com/apache/beam/pull/17244#discussion_r871689162
########## sdks/python/apache_beam/internal/gcp/auth.py: ########## @@ -59,7 +73,7 @@ def set_running_in_gce(worker_executing_project): executing_project = worker_executing_project -def get_service_credentials(): +def get_service_credentials(pipeline_options): Review Comment: yea if `None` is a valid type, then mention in the docstring what it means -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
