lostluck commented on code in PR #17635:
URL: https://github.com/apache/beam/pull/17635#discussion_r871700297
##########
sdks/go/examples/snippets/04transforms.go:
##########
@@ -185,6 +190,8 @@ func formatCoGBKResults(key string, emailIter, phoneIter
func(*string) bool) str
func init() {
beam.RegisterFunction(formatCoGBKResults)
Review Comment:
This reveals we may want to also have a series of `register.FuncDoFn` for
func DoFns, which should be very similar but much much simpler than the struct
ones.
##########
sdks/go/examples/snippets/04transforms.go:
##########
@@ -185,6 +190,8 @@ func formatCoGBKResults(key string, emailIter, phoneIter
func(*string) bool) str
func init() {
beam.RegisterFunction(formatCoGBKResults)
Review Comment:
Whoops missed publishing these before you closed it.
WRT documentation changes, we likely do want to hold on making the beam
package GoDoc mention these until we're unblocked from the import process.
But the other example code (everything in beam/examples) and integration
test code can certainly make use of it before then. Doesn't need to be all at
once, we can divide it amongst the team so folks can get used to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
