mosche commented on code in PR #17662:
URL: https://github.com/apache/beam/pull/17662#discussion_r872459752
##########
runners/spark/spark_runner.gradle:
##########
@@ -218,29 +218,17 @@ def validatesRunnerBatch =
tasks.register("validatesRunnerBatch", Test) {
group = "Verification"
// Disable gradle cache
outputs.upToDateWhen { false }
- def pipelineOptions = JsonOutput.toJson([
- "--runner=TestSparkRunner",
- "--streaming=false",
- "--enableSparkMetricSinks=false",
- ])
- systemProperty "beamTestPipelineOptions", pipelineOptions
- systemProperty "beam.spark.test.reuseSparkContext", "true"
- systemProperty "spark.ui.enabled", "false"
- systemProperty "spark.ui.showConsoleProgress", "false"
+ systemProperties sparkTestProperties(["--enableSparkMetricSinks":"false"])
classpath = configurations.validatesRunner
testClassesDirs = files(
project(":sdks:java:core").sourceSets.test.output.classesDirs,
project(":runners:core-java").sourceSets.test.output.classesDirs,
)
- testClassesDirs += files(project.sourceSets.test.output.classesDirs)
Review Comment:
All unit tests should be run as part of the `test` task
##########
runners/spark/spark_runner.gradle:
##########
@@ -218,29 +218,17 @@ def validatesRunnerBatch =
tasks.register("validatesRunnerBatch", Test) {
group = "Verification"
// Disable gradle cache
outputs.upToDateWhen { false }
- def pipelineOptions = JsonOutput.toJson([
- "--runner=TestSparkRunner",
- "--streaming=false",
- "--enableSparkMetricSinks=false",
- ])
- systemProperty "beamTestPipelineOptions", pipelineOptions
- systemProperty "beam.spark.test.reuseSparkContext", "true"
- systemProperty "spark.ui.enabled", "false"
- systemProperty "spark.ui.showConsoleProgress", "false"
+ systemProperties sparkTestProperties(["--enableSparkMetricSinks":"false"])
classpath = configurations.validatesRunner
testClassesDirs = files(
project(":sdks:java:core").sourceSets.test.output.classesDirs,
project(":runners:core-java").sourceSets.test.output.classesDirs,
)
- testClassesDirs += files(project.sourceSets.test.output.classesDirs)
- // Only one SparkContext may be running in a JVM (SPARK-2243)
- forkEvery 1
maxParallelForks 4
useJUnit {
includeCategories 'org.apache.beam.sdk.testing.ValidatesRunner'
- includeCategories 'org.apache.beam.runners.spark.UsesCheckpointRecovery'
Review Comment:
Unit test!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
