pskevin commented on code in PR #17580:
URL: https://github.com/apache/beam/pull/17580#discussion_r872876133
##########
sdks/typescript/package.json:
##########
@@ -32,6 +32,7 @@
"chai": "^4.3.4",
"date-fns": "^2.28.0",
"fast-deep-equal": "^3.1.3",
+ "find-git-root": "^1.0.4",
Review Comment:
You're right in the principle of having shared tiny packages. Problem (as
evidenced over the last decade) is that the scope of what is considered to be a
module is arbitrarily small. Loads of troll modules exist that do nothing
comprehensive and eventually add to operational toil (versions, lock files,
security checks etc.).
I usually see the code of the module and determine if it doing "reasonable"
work to add it as a dependency. There could also be a trade-off some times
since enthusiastic module authors lean strongly towards "generalize everything"
(as they should) which may not serve long term evolving needs. This usually
leads me to adopt the generalized code and tweak it to our specific use case
instead of depending on a generalized module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
