Abacn commented on code in PR #17682:
URL: https://github.com/apache/beam/pull/17682#discussion_r874150664
##########
sdks/python/apache_beam/dataframe/frames_test.py:
##########
@@ -1723,28 +1729,24 @@ def test_groupby_callable(self):
def test_groupby_apply(self):
df = GROUPBY_DF
-
- def median_sum_fn(x):
- return (x.foo + x.bar).median()
-
Review Comment:
Yeah I agree with the idea. Given the amount of code added I considered pick
up them into a separate helper function. Nevertheless it is still in the
GroupByTest test class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
