igorbernstein2 commented on code in PR #16939:
URL: https://github.com/apache/beam/pull/16939#discussion_r877197940
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableServiceImpl.java:
##########
@@ -334,4 +554,108 @@ public List<SampleRowKeysResponse>
getSampleRowKeys(BigtableSource source) throw
return session.getDataClient().sampleRowKeys(request);
}
}
+
+ @VisibleForTesting
+ public static ServiceCallMetric populateReaderCallMetric(
Review Comment:
nit. I would name this : createCallMetric(session, tableId).
Populate implies that the instance already exists
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
