aromanenko-dev commented on code in PR #17163:
URL: https://github.com/apache/beam/pull/17163#discussion_r878459304


##########
sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/JmsIO.java:
##########
@@ -48,13 +49,18 @@
 import org.apache.beam.sdk.transforms.DoFn;
 import org.apache.beam.sdk.transforms.PTransform;
 import org.apache.beam.sdk.transforms.ParDo;

Review Comment:
   Was not it possible to avoid this breaking change? Like, add new 
functionality and keep a previous one  deprecated? 
   
   Just tested the latest Beam 2.39.0 RC2 and my job with JmsIO.write() failed 
to compile without additional code changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to