[GitHub] [beam] Miuler commented on a diff in pull request #17511: [BEAM-14004] fix(mongodb): Ignore error Command not supported because of CosmosDB not support splitKeys command #16972

Sat, 21 May 2022 04:44:58 -0700 


Miuler commented on code in PR #17511:
URL: https://github.com/apache/beam/pull/17511#discussion_r878686480


##########
sdks/java/io/mongodb/src/main/java/org/apache/beam/sdk/io/mongodb/MongoDbIO.java:
##########
@@ -489,8 +490,16 @@ public List<BoundedSource<Document>> split(
             // maxChunkSize is the Mongo partition size in MB
             LOG.debug("Splitting in chunk of {} MB", desiredBundleSizeBytes / 
1024 / 1024);
             splitVectorCommand.append("maxChunkSize", desiredBundleSizeBytes / 
1024 / 1024);
-            Document splitVectorCommandResult = 
mongoDatabase.runCommand(splitVectorCommand);
-            splitKeys = (List<Document>) 
splitVectorCommandResult.get("splitKeys");
+            try {

Review Comment:
   They unit test only work with one cosmosdb embebed versión.
   This case just happen con cosmos or some implementation not standard, only 
for the command `splitVector` @johnjcasey 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to