lukecwik commented on code in PR #17169:
URL: https://github.com/apache/beam/pull/17169#discussion_r879806838
##########
sdks/python/apache_beam/io/gcp/pubsublite/external.py:
##########
@@ -30,8 +30,7 @@
_ReadSchema = typing.NamedTuple(
'_ReadSchema',
- [('subscription_path', str), ('min_bundle_timeout', int),
- ('deduplicate', bool)])
+ [('subscription_path', str), ('deduplicate', bool)])
Review Comment:
```suggestion
```
##########
sdks/python/apache_beam/io/gcp/pubsublite/external.py:
##########
@@ -30,8 +30,7 @@
_ReadSchema = typing.NamedTuple(
'_ReadSchema',
Review Comment:
```suggestion
'_ReadSchema', [('subscription_path', str), ('deduplicate', bool)])
```
##########
sdks/python/apache_beam/io/gcp/pubsublite/external.py:
##########
@@ -79,7 +71,6 @@ def __init__(
NamedTupleBasedPayloadBuilder(
_ReadSchema(
subscription_path=subscription_path,
Review Comment:
```suggestion
subscription_path=subscription_path,
deduplicate=deduplicate)),
```
##########
sdks/python/apache_beam/io/gcp/pubsublite/external.py:
##########
@@ -79,7 +71,6 @@ def __init__(
NamedTupleBasedPayloadBuilder(
_ReadSchema(
subscription_path=subscription_path,
- min_bundle_timeout=min_bundle_timeout,
deduplicate=deduplicate)),
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
