damccorm commented on code in PR #17471:
URL: https://github.com/apache/beam/pull/17471#discussion_r882643729
##########
runners/direct-java/build.gradle:
##########
@@ -178,6 +192,26 @@ task validatesRunner(type: Test) {
}
}
+tasks.register("validatesRunnerSickbay", Test) {
+ group = "Verification"
+ description "Validates Direct runner (Sickbay Tests)"
+ systemProperty "beamTestPipelineOptions", JsonOutput.toJson([
+ "--runner=DirectRunner",
+ ])
+
+ classpath = configurations.needsRunner
+ testClassesDirs =
files(project(":sdks:java:core").sourceSets.test.output.classesDirs)
+
+ filter {
+ for (String test : sickbayTests) {
+ includeTestsMatching test
+ }
+
+ // https://issues.apache.org/jira/browse/BEAM-4191
+ includeTestsMatching
'org.apache.beam.runners.direct.WatermarkManagerTest.updateWatermarkWithDifferentWindowedValueInstances'
Review Comment:
Whoops, accidentally deleted a comment, but I'm still unclear why this can't
be included in sickbayTests
##########
runners/direct-java/build.gradle:
##########
@@ -178,6 +192,26 @@ task validatesRunner(type: Test) {
}
}
+tasks.register("validatesRunnerSickbay", Test) {
Review Comment:
Yeah, actually taking another look I think you're right that this is more
trouble than its worth, especially since we also need the tests in
needsRunnerTests so there's not a super clean way to pull them out. Thanks for
pushing on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
