fernando-wizeline commented on code in PR #17471:
URL: https://github.com/apache/beam/pull/17471#discussion_r882807538
##########
runners/direct-java/build.gradle:
##########
@@ -178,6 +192,26 @@ task validatesRunner(type: Test) {
}
}
+tasks.register("validatesRunnerSickbay", Test) {
+ group = "Verification"
+ description "Validates Direct runner (Sickbay Tests)"
+ systemProperty "beamTestPipelineOptions", JsonOutput.toJson([
+ "--runner=DirectRunner",
+ ])
+
+ classpath = configurations.needsRunner
+ testClassesDirs =
files(project(":sdks:java:core").sourceSets.test.output.classesDirs)
+
+ filter {
+ for (String test : sickbayTests) {
+ includeTestsMatching test
+ }
+
+ // https://issues.apache.org/jira/browse/BEAM-4191
+ includeTestsMatching
'org.apache.beam.runners.direct.WatermarkManagerTest.updateWatermarkWithDifferentWindowedValueInstances'
Review Comment:
Oh, about this one: I'm using the same sickbayTests in both needsRunnerTests
and validatesRunnerSickbay. For some reason, when I remove the @Ignore tag from
the updateWatermarkWithDifferentWindowedValueInstances method in class
WatermarkManagerTest and rely solely on the excludeTestsMatching instruction,
the test gets executed anyway. I'm not really knowledgeable in Gradle, so I'm
pretty sure there's something I'm missing.
The quickest workaround I came up with was to just leave the @Ignore tag
there and add the test directly to the validatesRunnerSickbay task.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
