TheNeuralBit commented on code in PR #17771: URL: https://github.com/apache/beam/pull/17771#discussion_r883122160
########## sdks/python/apache_beam/typehints/batch.py: ########## @@ -104,6 +110,12 @@ def __hash__(self) -> int: class ListBatchConverter(BatchConverter): + SAMPLE_FRACTION = 0.2 Review Comment: Similarly here, this is just an arbitrary sample rate. Should we try harder to keep this consistent with the reservoir sampling done in `OperationCounters`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
