KevinGG commented on code in PR #17736:
URL: https://github.com/apache/beam/pull/17736#discussion_r883122855


##########
sdks/python/apache_beam/runners/interactive/interactive_beam.py:
##########
@@ -475,7 +485,9 @@ def cleanup(
             'options is deprecated since First stable release. References to '
             '<pipeline>.options will not be supported',
             category=DeprecationWarning)
-        p.options.view_as(FlinkRunnerOptions).flink_master = '[auto]'
+        p_flink_options = p.options.view_as(FlinkRunnerOptions)
+        p_flink_options.flink_master = '[auto]'
+        p_flink_options.flink_version = None

Review Comment:
   Because Dataproc only supports a constant Flink version and we always 
override to that version.
   We set it to None in case the user wants to use a different cluster (as the 
behavior indicates: clean up the cluster status for the given pipeline) but 
forgets to set the Flink version they want to use.
   
   Beam's default value is the latest hard coded published Flink version.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to