msbukal commented on code in PR #17741:
URL: https://github.com/apache/beam/pull/17741#discussion_r883859096
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java:
##########
@@ -1349,7 +1376,15 @@ public enum ContentStructure {
}
/** The type Execute bundles. */
- public static class ExecuteBundles extends Write {
+ public static class ExecuteBundles
+ extends PTransform<PCollection<FhirBundleParameter>,
ExecuteBundlesResult> {
+
+ /** The TupleTag used for bundles that were executed successfully. */
+ public static final TupleTag<FhirBundleResponse> SUCCESSFUL_BUNDLES = new
TupleTag<>();
+
+ /** The TupleTag used for bundles that failed to be executed for any
reason. */
+ public static final TupleTag<HealthcareIOError<FhirBundleResponse>>
FAILED_BUNDLES =
Review Comment:
I'd keep the HealthcareIOError as `HealthcareIOError<FhirBundleParameter>`
since you aren't adding a response to the FhirBundleResponse, so a user might
be confused why the response field is empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
