aijamalnk commented on code in PR #17594: URL: https://github.com/apache/beam/pull/17594#discussion_r884389676
########## website/www/site/content/en/contribute/committer-guide.md: ########## @@ -101,8 +101,9 @@ squash, split, etc, the commits, so that the history is most useful: * Favor commits that do just one thing. The commit is the smallest unit of easy rollback; it is easy to roll back many commits, or a whole pull request, but harder to roll back part of a commit. -* Commit messages should tag JIRAs and be otherwise descriptive. -It should later not be necessary to find a merge or first PR commit to find out what caused a change. +* Commit messages should be descriptive. It should later not be necessary to find a Review Comment: should commit messages also reference the issue number? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
