aaltay commented on code in PR #17708:
URL: https://github.com/apache/beam/pull/17708#discussion_r886240367
##########
sdks/python/apache_beam/io/fileio.py:
##########
@@ -525,8 +526,11 @@ def __init__(
@staticmethod
def _get_sink_fn(input_sink):
# type: (...) -> Callable[[Any], FileSink]
- if isinstance(input_sink, FileSink):
- return lambda x: input_sink
+ if isinstance(input_sink, type) and issubclass(input_sink, FileSink):
Review Comment:
For my learning, so this will work with:
sink=fileio.TextSink()
and
sink=fileio.TextSink
and previously it was only working with:
sink=fileio.TextSink
Is that correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
