TheNeuralBit commented on PR #17761: URL: https://github.com/apache/beam/pull/17761#issuecomment-1143910391
It still failed, it looks like we [cache ScopedState instances](https://github.com/apache/beam/blob/ca33943808c56ce634c92eb85f865285c71ee048/sdks/python/apache_beam/runners/worker/statesampler.py#L169-L170) and there are cases where they are re-used across operations. PreCommit is failing in the Dataflow worker now: ``` > self) E apache_beam.runners.dataflow.dataflow_runner.DataflowRuntimeException: Dataflow pipeline failed. State: FAILED, Error: E Traceback (most recent call last): E File "/usr/local/lib/python3.7/site-packages/dataflow_worker/batchworker.py", line 646, in do_work E work_executor.execute() E File "/usr/local/lib/python3.7/site-packages/dataflow_worker/executor.py", line 210, in execute E op.finish() E File "apache_beam/runners/worker/operations.py", line 1269, in apache_beam.runners.worker.operations.PGBKCVOperation.finish E File "apache_beam/runners/worker/operations.py", line 1272, in apache_beam.runners.worker.operations.PGBKCVOperation.finish E File "apache_beam/runners/worker/operations.py", line 1295, in apache_beam.runners.worker.operations.PGBKCVOperation.output_key E File "apache_beam/runners/worker/operations.py", line 528, in apache_beam.runners.worker.operations.Operation.output E File "apache_beam/runners/worker/operations.py", line 237, in apache_beam.runners.worker.operations.SingletonElementConsumerSet.receive E File "apache_beam/runners/worker/operations.py", line 240, in apache_beam.runners.worker.operations.SingletonElementConsumerSet.receive E File "dataflow_worker/shuffle_operations.py", line 214, in dataflow_worker.shuffle_operations.ReifyTimestampAndWindowsOperation.process E File "dataflow_worker/shuffle_operations.py", line 218, in dataflow_worker.shuffle_operations.ReifyTimestampAndWindowsOperation.process E File "apache_beam/runners/worker/operations.py", line 528, in apache_beam.runners.worker.operations.Operation.output E File "apache_beam/runners/worker/operations.py", line 237, in apache_beam.runners.worker.operations.SingletonElementConsumerSet.receive E File "apache_beam/runners/worker/operations.py", line 240, in apache_beam.runners.worker.operations.SingletonElementConsumerSet.receive E File "dataflow_worker/shuffle_operations.py", line 177, in dataflow_worker.shuffle_operations.ShuffleWriteOperation.process E File "apache_beam/runners/worker/statesampler_fast.pyx", line 235, in apache_beam.runners.worker.statesampler_fast.ScopedState.__enter__ E File "apache_beam/runners/worker/statesampler_fast.pyx", line 236, in apache_beam.runners.worker.statesampler_fast.ScopedState.__enter__ E AssertionError: Attempted to re-enter ScopedState[s05-s4-process-msecs, 235098419], which is unnecessary and unsupported ``` Maybe we need to make ScopedState support re-entering... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
