damccorm opened a new pull request, #17811: URL: https://github.com/apache/beam/pull/17811
Right now, running an SDF with a BundleFinalizer blows up with errors: `panic: runtime error: invalid memory address or nil pointer dereference goroutine 100`. It was working fine on non-SDFs. I was able to repro - failing pipeline: <img width="342" alt="image" src="https://user-images.githubusercontent.com/42773683/171641509-b3213dcb-1974-4aef-89b5-c9bd27867f11.png";> And after the fix the same pipeline succeeds: <img width="331" alt="image" src="https://user-images.githubusercontent.com/42773683/171641554-d787e1bc-061d-4d67-b604-d0e6b0781829.png";> I also verified that non-SDFs still don't have any issues This also fixes a doc bug with the programming guide which had the parameters misordered. ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`). - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier). To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md) GitHub Actions Tests Status (on master branch) ------------------------------------------------------------------------------------------------ [](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule) See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
![https://user-images.githubusercontent.com/42773683/171641509-b3213dcb-1974-4aef-89b5-c9bd27867f11.png"](https://user-images.githubusercontent.com/42773683/171641509-b3213dcb-1974-4aef-89b5-c9bd27867f11.png"){kind=link}
![https://user-images.githubusercontent.com/42773683/171641554-d787e1bc-061d-4d67-b604-d0e6b0781829.png"](https://user-images.githubusercontent.com/42773683/171641554-d787e1bc-061d-4d67-b604-d0e6b0781829.png"){kind=link}
