yirutang commented on code in PR #17779:
URL: https://github.com/apache/beam/pull/17779#discussion_r888155268
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/TableRowToStorageApiProto.java:
##########
@@ -348,6 +348,8 @@ static Object singularFieldToProtoValue(
return Double.valueOf((String) value);
} else if (value instanceof Double || value instanceof Float) {
return ((Number) value).doubleValue();
+ } else if (value instanceof Integer || value instanceof Long) {
+ return ((Number) value).longValue();
Review Comment:
I was not totally sure if int->double conversion will be accurate, but I
guess we will have to do the conversion here or there. Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
