jrmccluskey commented on code in PR #17813:
URL: https://github.com/apache/beam/pull/17813#discussion_r888189540
##########
sdks/go/pkg/beam/testing/passert/count.go:
##########
@@ -30,6 +30,10 @@ func Count(s beam.Scope, col beam.PCollection, name string,
count int) {
if typex.IsKV(col.Type()) {
col = beam.DropKey(s, col)
}
+
+ if count > 0 {
+ NonEmpty(s, col)
Review Comment:
Sum did need it, confirmed via unit test. Will add some short validation for
Hash
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
