y1chi commented on code in PR #17818:
URL: https://github.com/apache/beam/pull/17818#discussion_r889158954
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java:
##########
@@ -1196,7 +1196,7 @@ public static <DestinationT>
FileResultCoder<DestinationT> of(
@Override
public List<? extends Coder<?>> getCoderArguments() {
- return Arrays.asList(windowCoder);
+ return Arrays.asList(windowCoder, destinationCoder);
Review Comment:
So IIUC, the right thing to do is to have FileResult<WindowT, DestinationT>
so that coder inference can work for both window type and destination type. But
since all FileResult PCollections use explicit setCoders that's not a
requirement. I still think window coder needs to be in the components so that
FileResultCoder with different window coders won't collide with each other.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
