kennknowles opened a new issue, #18436: URL: https://github.com/apache/beam/issues/18436
The only tests I have found for `ValueProvider<?\>` parameterized methods is that they are not evaluated during pipeline construction time. This is missing out on several important pieces: 1. https://stackoverflow.com/questions/44967898/notify-when-textio-is-done-writing-a-file seems to be a problem with an AvroIO write using a RuntimeValueProvider being non-serializable (current theory is because of an anonymous inner class capturing the enclosing AvroIO.Write instance which has non-serializable fields). 2. Testing that the code paths that actually read the file do so correctly when parameterized. We should update the developer documentation to describe what the requirements are for a parameterized IO and provide guidance on what tests are needed and how to write them. Imported from Jira [BEAM-2577](https://issues.apache.org/jira/browse/BEAM-2577). Original Jira may contain additional context. Reported by: bchambers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
