kennknowles opened a new issue, #18684: URL: https://github.com/apache/beam/issues/18684
The following test https://github.com/apache/beam/pull/4239 demonstrates that stacked GBKs with accumulating mode are unsafe, the same way that stacked GBKs with merging windows are unsafe. In particular, in the pipeline: input -\> (gbk onto N keys) -\> ungroup -\> (gbk onto 1 key) -\> ungroup, e.g. suppose the first gbk receives "a" and then "b"; it will emit "a" and then "a","b" - then the second gbk will emit "a" and then "a","a","b" which is meaningless. With combine instead of GBK, it leads to double-counting. There are cases where accumulation propagated through stacked aggregation can be desirable, but having it propagate by default is definitely the wrong thing to do. Silently changing it to discarding is likely also the wrong thing to do. So, we should reset the windowing strategy and force the user to specify accumulating mode explicitly if they would like to. All pipelines using this currently are computing meaningless results, so rejecting them should not be considered a breaking change. However, we should still find out whether there are a lot of such pipelines or not. Imported from Jira [BEAM-3353](https://issues.apache.org/jira/browse/BEAM-3353). Original Jira may contain additional context. Reported by: jkff. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
