jayzhan211 commented on issue #10181: URL: https://github.com/apache/datafusion/issues/10181#issuecomment-2071461117
> done between the parse plan and the logical plan I had also thought about deprecate `Expr` and use functions directly in parsing phase. I think it might be a good idea. The downside of the current impl is that one needs to register function rewrite rule to convert Expr to Function. I think **Register** is better not a neccessary step for default behavior. If we have functions in parsing phase, no additional step (register rewrite) is needed. > What's the motivation for doing this at the logical level instead of doing this as part of the conversion from logical to physical? One good reason is that we don't need physical expr if we converted it to functions in logical level. I think the early we optimize, the less duplicated things we leave. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
