jayzhan211 commented on code in PR #10193:
URL: https://github.com/apache/datafusion/pull/10193#discussion_r1576155672
##########
datafusion/functions/src/math/random.rs:
##########
@@ -83,19 +84,13 @@ fn random(args: &[ColumnarValue]) -> Result<ColumnarValue> {
#[cfg(test)]
mod test {
- use std::sync::Arc;
-
- use arrow::array::NullArray;
-
use datafusion_common::cast::as_float64_array;
- use datafusion_expr::ColumnarValue;
- use crate::math::random::random;
+ use super::*;
#[test]
fn test_random_expression() {
- let args = vec![ColumnarValue::Array(Arc::new(NullArray::new(1)))];
- let array = random(&args)
+ let array = random(&[])
Review Comment:
remove this test, since it is already covered
https://github.com/apache/datafusion/blob/da82cece8181d5af0d38243229ecb2b4722cb4a9/datafusion/sqllogictest/test_files/expr.slt#L788-L790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
