waynexia commented on code in PR #10196:
URL: https://github.com/apache/datafusion/pull/10196#discussion_r1576371100
##########
.github/workflows/rust.yml:
##########
@@ -77,7 +77,7 @@ jobs:
run: cargo check --all-targets --no-default-features -p
datafusion-functions
- name: Check workspace in debug mode
- run: cargo check
+ run: cargo check --all-targets --workspace
Review Comment:
This should cover test modules
##########
Cargo.toml:
##########
@@ -130,3 +130,6 @@ rpath = false
[workspace.lints.clippy]
# Detects large stack-allocated futures that may cause stack overflow crashes
(see threshold in clippy.toml)
large_futures = "warn"
+
+[workspace.lints.rust]
+unused_imports = "deny"
Review Comment:
Deny unused import warning. Unfortunately, `cargo check` doesn't support
things like `-D warning` at present
https://github.com/rust-lang/cargo/issues/8424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
