phillipleblanc opened a new pull request, #10198:
URL: https://github.com/apache/datafusion/pull/10198
## Which issue does this PR close?
Closes #10197
## Rationale for this change
I'm using the Unparser.expr_to_sql function to translate a DataFusion Expr
into an expression for Spark Connect. Unlike most SQL engines, Spark doesn't
like quoting the column identifiers. I want to be able to generate an
expression like `a > 4` but currently I can only get `"a" > 4`
I believe this might be useful beyond Spark for other database systems that
can handle unquoted column identifiers.
## What changes are included in this PR?
Changes the DefaultDialect for the Unparser to return `Some('"')` for
`identifier_quote_style`, and then changes the usage of
`identifier_quote_style` to not unwrap to `"` if it is None, but pass the
Option through.
## Are these changes tested?
Yes
## Are there any user-facing changes?
No, this change is backwards-compatible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
