alamb commented on code in PR #10191:
URL: https://github.com/apache/datafusion/pull/10191#discussion_r1576684997
##########
datafusion/common/src/tree_node.rs:
##########
@@ -405,18 +405,17 @@ pub trait TreeNode: Sized {
/// Returns true if `f` returns true for any node in the tree.
///
/// Stops recursion as soon as a matching node is found
- fn exists<F: FnMut(&Self) -> bool>(&self, mut f: F) -> bool {
+ fn exists<F: FnMut(&Self) -> Result<bool>>(&self, mut f: F) ->
Result<bool> {
Review Comment:
👍
##########
datafusion/optimizer/src/utils.rs:
##########
@@ -97,20 +95,6 @@ pub fn log_plan(description: &str, plan: &LogicalPlan) {
trace!("{description}::\n{}\n", plan.display_indent_schema());
}
-/// check whether the expression is volatile predicates
Review Comment:
nice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
