jayzhan211 commented on PR #10193: URL: https://github.com/apache/datafusion/pull/10193#issuecomment-2074663133
How about adding num_rows to invoke function? Let user decide how to deal with args and num_rows? On Wed, Apr 24, 2024, 6:27 PM Kun Liu ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In datafusion/physical-expr/src/scalar_function.rs > <https://github.com/apache/datafusion/pull/10193#discussion_r1577661127>: > > > > // evaluate the function > match self.fun { > - ScalarFunctionDefinition::UDF(ref fun) => fun.invoke(&inputs), > + ScalarFunctionDefinition::UDF(ref fun) => { > + if fun.support_randomness() { > + fun.invoke_no_args(batch.num_rows()) > > Do we have any method to hide the special behavior? > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/datafusion/pull/10193#discussion_r1577661127>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ADZCLR3GAV44GZ2J76JUXXDY66CITAVCNFSM6AAAAABGUPBNIWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMJZGQ4TANZSGA> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
