viirya commented on PR #318: URL: https://github.com/apache/datafusion-comet/pull/318#issuecomment-2075783674
> That's right. Currently it is `spark-3.x` dir only, but I plan to add `spark-4.0` for example. If we want to split `spark-3.4` dir out of `spark-3.x` we can do so as follow up. I think the original idea is to have spark-3.2 and spark-3.3 shims which use reflection API, and spark-3.4 which uses Spark API as it is available. So for the Spark versions which have the API available, its shim layer doesn't need to use reflection. That's what I got from the ticket. I'm not sure if you are going to do that? If so, then it is fine to have this as initial move. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
