erratic-pattern commented on PR #10221: URL: https://github.com/apache/datafusion/pull/10221#issuecomment-2077669921
> > I may try to approach a solution from a different angle here, to avoid needing to refactor the type coercion logic too much without any clear understanding of what the impacts could be. > > FWIW I think the coercion is the right approach here. Let me take a look at this PR and see if I can find something I think it is the right approach for this one particular case, but the `coalesce` example in the tests is a good example of where you probably do want to convert to a simple integer type rather than converting everything to dictionaries. Maybe we need to decouple the non-comparison type coercions from using the `comparison_coercion` function and have their own coercion function(s). For example `VariadicEqual` functions can use a new `operand_coercion` function which does the same thing as the previous `comparison_coercion` function, but with `preserve_dictionaries` flag set to false. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
