jayzhan211 commented on PR #10188: URL: https://github.com/apache/datafusion/pull/10188#issuecomment-2078333183
> Once we have created a Arc<dyn PhysicalExpr> I don't really understand how/why we would ever get an Expr that we need to convert back to Arc<dyn PhysicalExpr> again. I think we don't have any need to convert physical expr back to expr. But, we need to convert expr to physical-expr, because `accumulator` and `reverse_expr` are the functions that need `ordering_req: Vec<PhysicalSortExpr>`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
