alamb commented on code in PR #10254:
URL: https://github.com/apache/datafusion/pull/10254#discussion_r1581342841


##########
datafusion/proto/src/generated/mod.rs:
##########
@@ -17,7 +17,6 @@
 
 #[allow(clippy::all)]
 #[rustfmt::skip]
-#[cfg(not(docsrs))]

Review Comment:
   I think this was added in  https://github.com/apache/datafusion/pull/3580 
but now that the code is vendored (doesn't require running protoc at compile 
time) I think it should work
   
   However, I don't really understand why it stopped working in the first place 
🤔 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to