JasonLi-cn commented on PR #10208: URL: https://github.com/apache/datafusion/pull/10208#issuecomment-2081447048
> Thanks @JasonLi-cn for this 👍 > > I noticed this from PG's [document](https://www.postgresql.org/docs/9.5/functions-aggregate.html): > > > . The arguments to the GROUPING operation are not actually evaluated, but they must match exactly expressions given in the GROUP BY clause of the associated query level. > > Do we need to do some verifications to make sure the param of `GROUPING` matches `GROUP BY`? Also I see the implementation of `GroupingGroupsAccumulator` assumes the input expr is column, but `GROUP BY` doesn't have such a constrain. Thanks @waynexia for your suggestion. I agree with you and I will make improvements according to your suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
