advancedxy commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1582496611
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -66,20 +71,65 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
castTest(testValues, DataTypes.BooleanType)
}
- ignore("cast string to byte") {
- castTest(generateStrings(numericPattern, 8).toDF("a"), DataTypes.ByteType)
- }
-
- ignore("cast string to short") {
- castTest(generateStrings(numericPattern, 8).toDF("a"), DataTypes.ShortType)
- }
-
- ignore("cast string to int") {
- castTest(generateStrings(numericPattern, 8).toDF("a"),
DataTypes.IntegerType)
- }
-
- ignore("cast string to long") {
- castTest(generateStrings(numericPattern, 8).toDF("a"), DataTypes.LongType)
+ private val castStringToIntegralInputs: Seq[String] = Seq(
Review Comment:
nit: Since the cast code handles leading and trailing white spaces, I think
we can add more input with white spaces.
For example:
```scala
castStringToIntegeralnputs.flatMap { x => Seq(" " + x, x + " ", " " + x
+ " ") }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
