jayzhan211 commented on code in PR #10268:
URL: https://github.com/apache/datafusion/pull/10268#discussion_r1583125654
##########
datafusion/expr/src/signature.rs:
##########
@@ -92,14 +92,22 @@ pub enum TypeSignature {
/// A function such as `concat` is `Variadic(vec![DataType::Utf8,
DataType::LargeUtf8])`
Variadic(Vec<DataType>),
/// One or more arguments of an arbitrary but equal type.
- /// DataFusion attempts to coerce all argument types to match the first
argument's type
+ /// DataFusion attempts to coerce all argument types to match to the
common type with comparision coercion.
///
/// # Examples
/// Given types in signature should be coercible to the same final type.
/// A function such as `make_array` is `VariadicEqual`.
///
/// `make_array(i32, i64) -> make_array(i64, i64)`
VariadicEqual,
+ /// One or more arguments of an arbitrary but equal type or Null.
+ /// Non-comparison coercion is attempted to match the signatures.
+ ///
+ /// Functions like `coalesce` is `VariadicEqual`.
+ // TODO: Temporary Signature, to differentiate existing VariadicEqual.
+ // After we swtich `make_array` to VariadicEqualOrNull,
+ // we can reuse VariadicEqual.
+ VariadicEqualOrNull,
Review Comment:
I think we need a similar signature but an exact args number for `nullif`
and `nvl`.
Can name it as `UniformEqual` compare to `VariadicEqual` 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
